search

wendall911 / TCIntegrations

A Minecraft 1.18+ mod designed to provide modpack integrations with other mods for Tinkers' Construct
MIT License
3 stars 5 forks source link

Emeraldite Shards in Smeltery/Foundry #49

Open sheshells opened 10 months ago

sheshells commented 10 months ago

The item "Emeraldite Shards" from the mod "Oh the Biomes You'll Go" when melted into its molten emerald counterpart has 5 extra mb of fluid granted to it.

Emeraldite shards are able to be crafted natively in BYG into emeralds at a ratio of 5:1. The melting process grants 25 mb of fluid.

One gem (one emerald) is 100 mb of fluid natively in tconstruct. This means that to keep the ratio the same from emeraldite shards it would require 20 mb of fluid.

If this is intentional I would recommend changing the bonus off of emeraldite shards and to emeraldite ore. Perhaps it should give a result of 1-2 extra shards per ore.

2024-01-14_13 01 28

sheshells commented 10 months ago

After a quick check, this is occurring in the latest version.

I noticed that the original use for this material is for pendorite alloy, using 2 shards to craft. It would be necessary to alter the alloying recipe to 40 mb of emerald rather than 50 mb.

Sorry for missing this!

wendall911 commented 6 months ago

Sorry for the very late response on this. This is just how Tinkers' Construct works. GEM_SHARD is defined as 25mb. I would rather not redifine how this is set. This sounds like a balancing issue with BYG, not TCIntegrations/TCon. If I have to do something special for every mod that does some weird math, I'd go crazy, as they end up fixing it and I then have to revert the change.

sheshells commented 5 months ago

No fret, this is a reasonable position to take. Thankfully your coding is amazing and I was able to work around it via datapack super easily.

wendall911 commented 5 months ago

Ok, awesome, I datapack everything to make sure it is flexible. (A few exceptions where things are hard-coded to match the integration mod specifically)

wendall911 commented 5 months ago

@sheshells Thank you for the compliment also, very much appreciated :100:

vizthex123 commented 1 week ago

Sorry for the very late response on this. This is just how Tinkers' Construct works. GEM_SHARD is defined as 25mb. I would rather not redifine how this is set. This sounds like a balancing issue with BYG, not TCIntegrations/TCon. If I have to do something special for every mod that does some weird math, I'd go crazy, as they end up fixing it and I then have to revert the change.

i feel like it's worth the exception in this case, given that the only item on both versions with the tag is BYG's shard. You could even keep the tag for other Shards and just set the item in the recipe for BYG's - that way you can just delete the custom recipe, add the shard to the tag, and be done.