search

wendlers / mpfshell

A simple shell based file explorer for ESP8266 Micropython based devices ⛺
MIT License
396 stars 84 forks source link

Change to setuptools, provide mpfshell entrypoint #51

Closed stlehmann closed 5 years ago

stlehmann commented 6 years ago

Setuptools entry_points make mpfshell more convenient. You can now simply type $ mpfshell in the commandline and mpfshell will start.

skorokithakis commented 5 years ago

Is this still relevant? There's an mpfshell script which does the same, no?

stlehmann commented 5 years ago

Hm, over time some fixes got mixed together in this Pull Request. Sorry for that.

Is this still relevant? There's an mpfshell script which does the same, no?

Yes, it is still relevant. The mpfshell script can't be used standalone on Windows because it has no file extension. Windows uses file extensions to determine which application to use for running. We could rename it "mpfshell.py" but then we would need to call "mpfshell.py" from the command line to start it. With the Entrypoints approach we have a platform independent solution that allows simply calling "mpfshell" whether you're on Windows, Linux or Mac.

skorokithakis commented 5 years ago

Can you split the fixes up? That way we can discuss and merge them separately. I'm all for using entrypoint if it doesn't interfere with usage on other platforms, and can merge that immediately.

skorokithakis commented 5 years ago

This has been merged in #51, thanks!