search

wendlers / mpfshell

A simple shell based file explorer for ESP8266 Micropython based devices ⛺
MIT License
396 stars 84 forks source link

fix enter repl in win10 console out garbled code when used Special keys #67

Closed junhuanchen closed 5 years ago

junhuanchen commented 5 years ago

such as up/down/left/right/tab/backspace/enter.....

skorokithakis commented 5 years ago

This is looking good, I don't have Windows so I can't test this and I don't have experience with it, but if it works for you, that's fine with me. It doesn't seem to do anything if the OS is anything other than Windows, so it shouldn't break anything else either.

junhuanchen commented 5 years ago

This is looking good, I don't have Windows so I can't test this and I don't have experience with it, but if it works for you, that's fine with me. It doesn't seem to do anything if the OS is anything other than Windows, so it shouldn't break anything else either.

This can rest assured that I have in WIN7 and WIN10 to provide my customer groups to use.

It has also been tested on Linux and Mac. It doesn't affect other systems.(if os.name == 'nt': # noqa)

skorokithakis commented 5 years ago

Great, thank you. If you can add some comments to make it clearer what's going on, I can merge.

junhuanchen commented 5 years ago

Great, thank you. If you can add some comments to make it clearer what's going on, I can merge.

You'd better test it yourself.I am not sure where to add comments, I seldom have the habit of comments, because I do not know where others can not understand.

skorokithakis commented 5 years ago

I seldom have the habit of comments, because I do not know where others can not understand.

Yeah, it's definitely a skill that must come with experience. I don't have a Windows machine to test it, unfortunately, so I'll merge and take your word for it. Thank you for the help!