search

wendlers / mpfshell

A simple shell based file explorer for ESP8266 Micropython based devices ⛺
MIT License
396 stars 84 forks source link

Impossible to exit REPL on some keyboard layouts #78

Closed powermosfet closed 5 years ago

powermosfet commented 5 years ago

On certain keyboard layouts, you need a modifier key to type ], and this makes the REPL not recognize it.

Specifically, I use a nordic layout, and I'm on Linux.

Perhaps there should be an option to enable the Windows-variant, Ctlr-Q

I have to either modify the source code to change the keycode, or close the whole terminal when I want to get out of the REPL

skorokithakis commented 5 years ago

Hmm, which modifier key do you need to press?

powermosfet commented 5 years ago

To type a ] i need to hold down AltGr and press 9, so Ctrl+] kind of becomes Ctrl+AltGr+9 but that does not work.

I have the changed to self.repl.exit_character = chr(0x03) locally so I can exit with Ctrl+C

skorokithakis commented 5 years ago

Oh I see. Sure, if it won't conflict with anything else, an alias would be nice. Do you have any time to work on this? If not, I can do it but it might take a while.

powermosfet commented 5 years ago

I can make a PR, sure.

I think the cleanest option would be to have a command line flag that force it to to use Ctrl+Q, even on non-windows systems. Do you agree?

$ mpfshell -o ttyUSB0 -q

$ mpfshell -o ttyUSB0 --ctrl-q
skorokithakis commented 5 years ago

That sounds good, although I'm wondering if there's value in making it settable (--exit-key=q), but it should probably work your way if that's a standard key combo.

Also, it might not even be an option but just a default key so both work, since this combination is currently unused, AFAIK.

powermosfet commented 5 years ago

Ok, this is really weird.

I set out to make a pull request for this today, and when I tested it, the Ctrl+] combination... worked. So yeah. I'm a bit stumped. I don't know why it didn't work before or what has changed since then.

So I guess this has become non-issue. :laughing:

skorokithakis commented 5 years ago

Oh I hate those kinds of problems :P I've had my fair share of reported bugs that worked when I tried them again. Let me know if you hit this problem again and manage to reproduce it!