wendtke / psyphr

legacy repo for R package suite for psychophysiological data; see github.com/psyphr-dev
1 stars 1 forks source link

Follow {tidyverse} principles #56

Open wendtke opened 5 years ago

wendtke commented 5 years ago

In addition to reading

consider (@geanders suggestions):

iqis commented 5 years ago
  1. I wonder what does "allow functions to retain order" mean?
  2. This can be a good option if we have a lot of functions and some may have namespace collision with other packages. I doubt if that's necessary for now.
  3. Let's bring this up in the next talk.
  4. Good idea.
  5. ditto
  6. ditto; do we want to test the water with a creating package for BIDS? I've taken a look at their Python package, it's pretty simple compared to WFDB.
wendtke commented 5 years ago
  1. I wonder what does "allow functions to retain order" mean?

I think it means we don't have to reorganize the order of functions within .R scripts.

  1. This can be a good option if we have a lot of functions and some may have namespace collision with other packages. I doubt if that's necessary for now.

It could also help with user-friendliness; newer users who aren't as familiar with function names and purposes might like the tab-completion option of psyphr_* or psyphr_tidy_*.

  1. Let's bring this up in the next talk.

Okay, I made a new doc.

  1. Good idea.

She said creating geoms is difficult and would help when the time came.

  1. ditto

Ditto what? Good idea or paste on Monday's agenda?

  1. ditto; do we want to test the water with a creating package for BIDS? I've taken a look at their Python package, it's pretty simple compared to WFDB.

I think we should get this package out the door first then explore the modular options. We should be very deliberate in how we name things, though. Maybe "psyphr" should be the umbrella package.