wenet-e2e / wespeaker

Research and Production Oriented Speaker Verification, Recognition and Diarization Toolkit
Apache License 2.0
688 stars 116 forks source link

How to solve: cannot import name 'vad' from 'silero_vad' #304

Closed shinshoji01 closed 6 months ago

shinshoji01 commented 6 months ago

In the latest version of "silero_vad", they have updated the structure of the repo and vad.py is no longer available in the folder "silero_vad". Therefore, the following part causes an error when you import wespeaker.

https://github.com/wenet-e2e/wespeaker/blob/5b8330bb5cbef4cdb9bd435eef0b8b78bff4c8e5/wespeaker/cli/speaker.py#L20

Therefore, we need to specify the commit id of the repository "silero_vad". I suggest the following update.

https://github.com/wenet-e2e/wespeaker/blob/5b8330bb5cbef4cdb9bd435eef0b8b78bff4c8e5/requirements.txt#L24

JiJiJiang commented 6 months ago

@pengzhendong Please follow this issue. There are recent updates in your repo https://github.com/pengzhendong/silero-vad.git. It seems that the vad.py file was deleted. What is the difference between silero_vad.py and the original vad.py? And how to fix this error here?

pengzhendong commented 6 months ago

@pengzhendong Please follow this issue. There are recent updates in your repo https://github.com/pengzhendong/silero-vad.git. It seems that the vad.py file was deleted. What is the difference between silero_vad.py and the original vad.py? And how to fix this error here?

I changed it. I will upload it to pypi and make a pr. No difference.

JiJiJiang commented 6 months ago

fixed!

wsstriving commented 6 months ago

Close as it has been fixed