search

wengkit1 / pe

0 stars 0 forks source link

some predicates are not mentioned in implementation of add_appointment #11

Open wengkit1 opened 1 year ago

wengkit1 commented 1 year ago

Start time before end time predicate missing from sequence. Screenshot 2023-04-14 at 3.27.16 PM.png

Screenshot 2023-04-14 at 3.26.12 PM.png

It should be mentioned in sequence, as the code checks for start time before end time before an appointment is added.

nus-se-bot commented 1 year ago

Team's Response

Thanks for the bug report. However in our implementation, the check for start time before end time happens within the ParserUtil class (when the constructor of TimeSlot is called by ParserUtil with a timeslot string, it calls checkArgument(startingDateTime.isBefore(endingDateTime), MESSAGE_START_AFTER_END) to ensure this). Since this is an implementation detail of the ParserUtil class, it is common to any appointment-related command, and we omitted this low level detail from the sequence diagram for AddAppointmentCommand.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The purpose of highlighting both sequence diagrams, is to show that ParserUtil is not referenced by either. Since this constraint is unique to your app, I hope you can understand from your own explanation, how this might be confusing to some.