nus-pe-bot
commented
1 year ago Team's Response
Hi, thanks for the bug report. However, patient and appointment are not separate entities - an appointment requires a patient name, so it is by definition connected to a specific patient. As you pointed out,
the app does not even allow same name individuals to be added
the app does not allow two people with the exact same name to be added.
it is unknown whether the John Doe in appointments list is the same as John Doe in the patients list.
This statement is incorrect, there can only be one John Doe in the patient list, so if there is an appointment for John Doe, it is guaranteed to be the same one from the patient list. (Note that if you tried to add an appointment for a patient who isn't in the patient list, add_appt will throw an error, so John Doe must exist in the patient list before you can add an appointment for them).
Therefore I contend that this bug should be rejected.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Sorry I was not clear enough in my explanation section. What I meant in this case, is not what is behaviour in the app, but the case if another 'John Doe' not from the patient's list enters the clinic and makes an appointment.
In the above scenario, while the app is allowing an appointment with the name John Doe to be made, it is unknown that John Doe in list, is the same John Doe making the appointment. But I do think this could be a feature flaw instead, even though it may be crossing the line of functionality.
Bug Title: Patients and appointments are separate entities.
Description
When I attempt to assign a patient to an appointment, there is no such user command.
Steps to Reproduce
Expected behavior
The patient should be assigned to an appointment with their last four digits nric and phone number for example for unique identification, as a candidate key.
Actual behavior
The patient can be added, and the appointment associated with the patient name can be added.
Environment
Additional Information
Severity and type
This is a medium functionality flaw, as the following behaviour causes problems beyond the scope of a feature flaw. The reason is that there are multiple people that may have same names, that go to different appointments. Since the app does not even allow same name individuals to be added, and has no command for assigning individuals to appointments, it is unknown whether the John Doe in appointments list is the same as John Doe in the patients list.