wengong-jin / icml18-jtnn

Junction Tree Variational Autoencoder for Molecular Graph Generation (ICML 2018)
MIT License
509 stars 190 forks source link

Necessity of benzynes and penzynes default values #49

Open wderekjones opened 5 years ago

wderekjones commented 5 years ago

In the code for the Vocab class, benzynes and penzynes are defined as attributes of the Vocab class outside of the init method, which I am not sure why. Furthermore however, these initialized lists are overwritten by a list comprehension that does not use any of the initial values from the lists, i.e. the initialized values are never used. I checked this behavior by instantiating a Vocab object with an empty list, as well as others using different vocabs that I have extracted. This appears to be extra code that could be removed without impacting the functionality of the network.