search

wengxyu1030 / DHS-Recode-IV

0 stars 1 forks source link

Code logic is not working #23

Open wengxyu1030 opened 2 years ago

wengxyu1030 commented 2 years ago

There's a dilemma in the code: if the variable doesn't exit, the loop can't loop over using the 'varlist' option. For example, when running this code through BurkinaFaso2003, the code will ger warning: variable m57e not found, @robin-wang please confirm if you can run it through on your end. https://github.com/wengxyu1030/DHS-Recode-IV/blob/45c82737355f126f5b2ad9f96329149a860a16cc/1_antenatal_care.do#L309-L314

robin-wang commented 2 years ago

Addressed. Thanks for spotting the bug. Now in master: https://github.com/wengxyu1030/DHS-Recode-IV/commit/75e598987aff805546c88f7c0c07350e8125ffd8

robin-wang commented 2 years ago

Propose to close.

wengxyu1030 commented 2 years ago

Thanks for correcting the logic here. @robin-wang kindly note that the same coding logic exists in the template DHS v， vi， and vii. Let's close it when all of them are addressed? Or if you prefer, you can close this one, and as for the others, they can be listed as new issues in each repo accordingly.

robin-wang commented 2 years ago

Hiya Aline, @wengxyu1030 DHS Recode V / VI / VII have all been mildly updated for this update. You might also notice some work-in-progress code put in place in the current push. These will be cleaned in due course, and code would be updated in the next round of push from my end to account for the addtional corrections we might be making.

Cheers! Thanks much for bringing order to our wrapping-up stage.