Senegal2019 revise - Githubissues

yining-sun commented 3 years ago

updated codes in 1.do- ANC
updated codes in 2.do- delivery care
updated 11.do- sleeping under bednet. Count both treated and nontreated as ITN. Recode mother education = 6 as missing.
Changed codes in 7.do child vaccination to ensure kids 15-23 months old receiving measles2 are coded as measles1.
Revised comments on Child Illness.

yining-sun commented 3 years ago

Dear both,

I rebased this branch from the master before making the changes. However, it might still be unable to merge automatically because I didn't rebase when I first checked this survey weeks ago.

wengxyu1030 commented 3 years ago

I see the changes you are making here are duplicated in Senegal 2018 #14 , @yining-sun please confirm. Please firstly follow my suggestions on #14 and pull request again for Senegal2018. Once this Senegal2018 is updated, the same code should work for Senegal 2019.

yining-sun commented 3 years ago

I see the changes you are making here are duplicated in Senegal 2018 #14 , @yining-sun please confirm. Please firstly follow my suggestions on #14 and pull request again for Senegal2018. Once this Senegal2018 is updated, the same code should work for Senegal 2019.

Dear Aline, I have updated the Senegal2018. Shall I pull the request for Senegal2019 again after the pull request for Senegal2018 is updated?

wengxyu1030 commented 3 years ago

I see the changes you are making here are duplicated in Senegal 2018 #14 , @yining-sun please confirm. Please firstly follow my suggestions on #14 and pull request again for Senegal2018. Once this Senegal2018 is updated, the same code should work for Senegal 2019.

Dear Aline, I have updated the Senegal2018. Shall I pull the request for Senegal2019 again after the pull request for Senegal2018 is updated?

Hi Yining, thanks for your feedback. I have reviewed your pull request of Senegal2018 and merged it to master. Please review if you have new updates in Senegal2019 comparing to Senegal2018 ( I have checked and to me it looks the updated template should work perfectly for Senegal2019), if you could confirm there's no further issue to be updated in Senegal2019, I will close this pull-request.

wengxyu1030 commented 3 years ago

@yining-sun created another branch where the rebase issue is solved in that branch #16 , thereby I am closing this issue and pull request.

robin-wang commented 3 years ago

@wengxyu1030 Thank you!

wengxyu1030 / DHS-Recode-VII

Senegal2019 revise #15