wengxyu1030 / DHS-Recode-VII

1 stars 5 forks source link

Jiangning #39

Closed a24680bjiang closed 2 years ago

robin-wang commented 2 years ago

I am not merging your work into the master branch just yet, pending our discussion on the decisons you made. Additionally, we typially try to link the branch/pull request with the issue (or checklist).

31

robin-wang commented 2 years ago

On the changes you have made, It is indeed possible that you have checked everything but no changes would be proposed. In practice, I'd expect some questions coming from your end, focusing on the definitions/providers to be processed in our regular expression sections across the many programme files. This is another point we need to cover in our discussion