wengxyu1030 / DHS-Recode-VII

1 stars 5 forks source link

Senegal2019 #4

Closed wengxyu1030 closed 3 years ago

wengxyu1030 commented 3 years ago

WORKFLOW DOC

A. General Procedural Steps

B. Checklist and Guidance

wengxyu1030 commented 3 years ago

Hi Yining, thanks a lot for your pull request. Could you let us know the result of the cross-validation between statistics from your microdata output and the survey report? I see currently it's missing in the checklist.

robin-wang commented 3 years ago

Hi Yining and Aline, thank you for addressing the bottleneck on quality control. For the moment, let's proceed without that step.

@yining-sun I want to ask if you could modify the way checks/changes are documented.

It would make this process super clean. Thanks for your work!

yining-sun commented 3 years ago

Hi Yining, thanks a lot for your pull request. Could you let us know the result of the cross-validation between statistics from your microdata output and the survey report? I see currently it's missing in the checklist.

@wengxyu1030 Hi Aline, I forgot to check that because similar to the Senegal2018 survey, there is no matched surveyid in the HEFPI.dta and DHS.dta. Therefore, there won't be any intermediate or final quality control observations.

yining-sun commented 3 years ago

Hi Yining and Aline, thank you for addressing the bottleneck on quality control. For the moment, let's proceed without that step.

@yining-sun I want to ask if you could modify the way checks/changes are documented.

  • Now you inserted changes in the original content of this issue, and, there is a separete comment where additional changes / checks are validated.
  • Would it be possible to move everything to the original checklist? You may do so by selecting "EDIT" option on that section in this issue.
  • I understand the need to link your work to code update; you may leave that comment with # sign in place, but doing so with only indications of the fact that this particular survey has been sufficiently addressed, and if there are any caveats you'd like to highlight.

It would make this process super clean. Thanks for your work!

Hi Robin, I have updated the original comment accordingly and deleted the additional one. I strictly followed the previous version of work flow instructions, but I agree, this version looks cleaner.

wengxyu1030 commented 3 years ago

Hi Yining, thanks a lot for your pull request. Could you let us know the result of the cross-validation between statistics from your microdata output and the survey report? I see currently it's missing in the checklist.

@wengxyu1030 Hi Aline, I forgot to check that because similar to the Senegal2018 survey, there is no matched surveyid in the HEFPI.dta and DHS.dta. Therefore, there won't be any intermediate or final quality control observations.

Dear Yining. Thanks for your feedback. I would clarify that this bullet point is requesting the cross-validation of statistics between the microdata you produced and the ones presented in the DHS report. For every survey, there's a report published together with the data, which you can find in the raw data folder. The report has detailed descriptions of the statistics and usually has the survey questions in the annex. This is different than the embedded quality-checking module, the module is useful in terms of cross-checking a subset of the indicators, however, there are also cases where the report contains the statistics that not incorporated in the cross-checking module in the template.

In cases like this where the embedded quality-checking module is not functioning as there are not published standardized indicator values yet from the DHS API, the survey report is particularly helpful as a reference point that it contains the statistics that you can use to cross-checking the microdata you produced.

wengxyu1030 commented 3 years ago

There are conflicts in merge pull requests due to untimely syncing. Aline resolved manually but expects in the future that the coders could use rebase together with fetch function in GitHub desktop to keep the branch synced avoiding conflicts.

Xian152 commented 3 years ago

@yining-sun @robin-wang Comments: Senegal2019 are quite similiar to Senegal2018, so we are encountered with similiar issues, including vaccination, c_anc_skill and c_sba.

Besides: 11.do: v106(education) =6 "other" . I haven't seen this before. No explaination of "other" in the report. I suppose we should code w_mateduc and as missing for this case. Better double check with Sven.