wenkokke / setup-agda

Set up a specific version of Agda for your GitHub Actions workflow.
Other
26 stars 3 forks source link

`outputs.agda-version` is empty #183

Closed andreasabel closed 1 year ago

andreasabel commented 1 year ago

With workflow steps like this:

env:
  AGDA_VERSION: 2.6.3
  STDLIB_VERSION: 1.7.1
...
      - name: Setup Agda
        uses: wenkokke/setup-agda@latest
        id:   setup
        with:
          agda-version: ${{ env.AGDA_VERSION }}
          agda-stdlib-version: ${{ env.STDLIB_VERSION }}

      - name: Cache build
        uses: actions/cache@v3
        id:   cache
        with:
          key: agda-${{ steps.setup.outputs.agda-version }}-stdlib-${{ env.STDLIB_VERSION }}

I get an empty steps.setup.outputs.agda-version, as witnessed in this workflow run: https://github.com/graded-type-theory/graded-type-theory/actions/runs/5093788246/jobs/9156820105#step:4:3

Run actions/cache@v3
  with:
    key: agda--stdlib-1.7.1

I am using latest (2023-02-07).

wenkokke commented 1 year ago

Oh, I think it's only actually setting agda-path and agda-data-path!

andreasabel commented 1 year ago

But the intention is that it sets all of these, or? https://github.com/wenkokke/setup-agda/blob/abaf527ba6e7155e835fe3ebf941c5ee4eb9b6e2/action.yml#L212-L224 I guess actionlint learns from this list; it didn't alert me of an unknown output agda-version or so.

wenkokke commented 1 year ago

It's definitely the intention that these are set, otherwise it's quite difficult to figure what version you've installed when using "latest" or "recommended", so this is a bug that likely stuck in in v2.0.0 after I decoupled the Agda installation from the action itself.

Thanks for the pointer to actionlint, I'll plan to incorporate that into the test suite!