search

wenxin-c / CS2113-Practical-Exam

0 stars 0 forks source link

Invalid showrates command not handled #7

Open wenxin-c opened 1 year ago

wenxin-c commented 1 year ago

Describe the bug

Extra payload given to showrates are not accepted but extra arguments given to showrates are accepted, causing confusion and inconsistency.

To Reproduce Steps to reproduce the behavior:

  1. Launch program
  2. Input command: showrates
  3. Input command: showreates test
  4. Input command: showrates /test

Expected behavior

Step 3 and 4 should lead to invalid command

Actual behaviour

Step 3 leads to invalid command but step 4 is accepted as correct command\

Screenshots

image.png

Additional context

Add any other context about the problem here.

nus-se-script commented 1 year ago

Team's Response

This behaviour is functioning as expected and is not a bug. The command to call is simple showrates and any other input after this string is irrelevant. This behaviour is due to the nature of command line inputs , and furthermore we do not intend to have command with extra field to be considered as invalid commands.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response, however, I disagree with the rejection of the issue reported.

You mentioned that "we do not intend to have command with extra field to be considered as invalid commands". However, command showrates test is recognised as an invalid command as shown in the screenshot. Based on your response, this is an obvious bug in the application.

Moreoever, you mentioned that "any other input after this string is irrelevant", however, command showrates test is recognised as invalid, showing that the input (i.e. test) after showrates string is actually relevant and causes command to be recognised as invalid. This is again a contradiction between your response and the behaviour of your application.

Additionally, the command showrates /test is recognised as valid but command showrates test is recognised as invalid. There is indeed inconsistency between commands. Since command showrates /test is a valid command, users will logically expect that command showrates test will be valid as well. However, command showrates test is invalid. This will indeed cause confusion for users. Hence, this is a bug in the application.

Refer to screenshot in the bug report.