wenxin-c / CS2113-Practical-Exam

0 stars 0 forks source link

`viewtype` command does not work #9

Open wenxin-c opened 1 year ago

wenxin-c commented 1 year ago

Describe the bug

Follow the format viewtype CATEGORY CURRENCY with both parameters filled in, but the command is recognised as invalid

To Reproduce Steps to reproduce the behavior:

  1. Launch program
  2. Input command: food /2023-02-02 a/25.10 p/NUS
  3. Input command: food /2023-02-02 a/25.10 p/NUS
  4. Input command: viewtype Food SGD

Expected behavior

Be able to view all Food expenditures

Actual behaviour

Command is invalid

Screenshots

image.png

Additional context

Add any other context about the problem here.

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to handle case sensitivity

Describe the bug

Command keyword issued in capital letters but fail to recognise. Command keyword should not be case sensitive based on module website requirement This happens to all commands, making it very inconvenient for users.

To Reproduce Steps to reproduce the behavior:

  1. Launch program
  2. Input command: FOOD d/2023-02-02 a/25.10 p/NUS

Expected behavior

This expenditure get added into the list

Actual behaviour

This command, particularly 'FOOD' is not recognised

Screenshots

image.png

image.png

Additional context

Add any other context about the problem here.


[original: nus-cs2113-AY2223S2/pe-interim#1784] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for highlighting this issue.

Firstly, using the commands to add expenditures are not designed to be in capital letters. Additionally, it was not mentioned in the user or developer guides that the commands are case insensitive; should this be included in the user or developer guides, this would be an issue.

Secondly, the find feature, as addressed in the developer guide, is not designed to be case sensitive. Thus, this bug is beyond the scope of our application

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** Thank you for your response, however, I disagree with as case sensitivity is definitely considered as within scope. As mentioned in the module website, case sensitivity of something should follow the case sensitivity of the real world entity it represents. In this case, `food` and `FOOD` will definitely mean the same thing. Hence, the command should be case insensitive and both `food` and `FOOD` should be valid. ![image.png](https://raw.githubusercontent.com/wenxin-c/pe/main/files/3d785db5-c716-4470-a8e3-591918c74115.png) Although the user/developer guide does not mention that the commands are case insensitive, it **DOES NOT** mention it is case sensitive either. Hence, this is not a valid reason to justify that case sensitivity is not in scope. Moreover, in many modern operating system and CLI applications, the command keywords are case insensitive. For example, in Windows command line shell, both `help` and `HELP` are valid commands with the same usage. Since the user guide does not mention case sensitivity, users would expect commands to be case insensitive.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** Thank you for your response, however, I disagree with your response. Firstly, based on module website, severity.VeryLow is only used for flaws that are purely cosmetic and does not affect user usage. However, case sensitivity does affect user usage as some commands such as `FOOD` are recognised as invalid, hindering users from using the application. ![image.png](https://raw.githubusercontent.com/wenxin-c/pe/main/files/299a3635-89ab-4fb7-9419-5274ff77414e.png) Moreover, as mentioned in the report, this issue related to case sensitivity happens to all commands. Due to the huge number of commands involved and the limitation of space, only one example is chosen with screenshot attached. As the application is for users who can type fast based on project requirement, users will have a very high chance neglecting the upper or lower case of commands. Hence, this issue will definitely happen very often. The case sensitive command keywords of this application will cause inconvenience and hinder users from using this application. Based on module website, severity.Medium is used for "a flaw that causes occasional inconvenience to some users but they can continue to use the product", it is justified and reasonable that this issue should be of severity.Medium. ![image.png](https://raw.githubusercontent.com/wenxin-c/pe/main/files/73e88561-f595-4b78-8043-1f189ff6eb7e.png)