search

wepay / kafka-connect-bigquery

DEPRECATED. PLEASE USE https://github.com/confluentinc/kafka-connect-bigquery. A Kafka Connect BigQuery sink connector
Apache License 2.0
155 stars 192 forks source link

Too strong config validation for clustering option #290

Open zachary-povey opened 4 years ago

zachary-povey commented 4 years ago

I may have misunderstood, but in com.wepay.kafka.connect.bigquery.config.BigQuerySinkTaskConfig line 243 it seems that we are asserting that if timestampPartitionFieldName isn't set and bigQueryPartitionDecorator is set to false then the resulting table won't be partitioned (and thus we cannot cluster).

I don't believe this is the case, we will still be partitioned using the _PARTITIONTIME pseudo-column, however the messages will be assigned a partition by BigQuery based on when the message was received there - right?