Misc updates - Githubissues

weppos / actionmailer_with_request

A simple plugin to make the Rails request context available for generating URLs in ActionMailer.

MIT License

54 stars 8 forks source link

Misc updates #2

Closed eric1234 closed 13 years ago

eric1234 commented 13 years ago

I made a few misc updates to your plugin. The commit should summarize them.

Regarding the gem support:

I can publish it if you want or you can feel free to publish it under your own rubygems account.
I didn't know what "version" to call the gem so I just started with 0.0.1. Feel free to change it.

Regarding the default :to/:from support:

I was thinking about splitting the usernames out into separate methods so the mailer could override but that seemed to be overkill.

eric1234 commented 13 years ago

Dup of newer request.