fix exception caused by url_options.protocol having :// in it

weppos / actionmailer_with_request

A simple plugin to make the Rails request context available for generating URLs in ActionMailer.

MIT License

54 stars 8 forks source link

fix exception caused by url_options.protocol having :// in it #7

Closed rweng closed 10 years ago

rweng commented 11 years ago

see https://github.com/Mange/roadie/issues/52

request.protocol returns http://, at least in newer Rails versions. Remove the :// if it exists.

weppos commented 11 years ago

I inspected the issue you referenced and I'm not sure the culprit is this library. This library is simply passing the options it receives, it means the input it set to https:// somewhere else.

The patch will not fix the issue at all, because if in the future some other gem will set the protocol to http:++, then the issue will exist again and we cannot go ahead and strip everything.

Any chance you can investigate a little bit to find who's changing the protocol?