Extract SimpleBuilder to a separate file

[kuraga]

23 was closed but I think it's right that builders (there is one now - SimpleBuilder)

should be in separate files.

• Number of builders may be more than one;
• SimpleBuilder is just an instance (an example) of a builder. It's a standard way but it's not a class to inherit. It's just a one of the ways.
• SimpleBuilder has own test file but doesn't have own code file.

[weppos]

Can you explain the reason behind this choice?

[kuraga]

@weppos in description now.

[weppos]

Actually, there are two builders: Builder (the abstract class) and SimpleBuilder. There are a couple of reasons that retain me to merge this patch.

First, if we extract this file into simple_builder.rb, the original file will be called Breadcrumbs and will contain a Builder definition.

Second, this file breaks the convention Namespace::ClassName => namespace/class_name.rb. To make things right, we should create lib/breadcrumbs_on_rails/breadcrumbs/simple_builder.rb, not lib/breadcrumbs_on_rails/simple_builder.rb.

I'm not sure this simple class deserves all this complexity.

[kuraga]

@weppos yes, it's my error about path. Fixed.

I think that abstract class may be not in separate file. But class that is just an example (yeah, but standard way) should.

I have wrote the reason. Thanks :-)

[weppos]

I appreciate your time and your contribution, however I believe I will keep all into this file until the need arises to extract it. For example, I will probably agree to extract it if I'll include and additional builder.

[kuraga]

:) compromise :-) :+1: