weppos / publicsuffix-ruby

Domain name parser for Ruby based on the Public Suffix List.
https://simonecarletti.com/code/publicsuffix
MIT License
620 stars 109 forks source link

allow usage under jruby for adventurous souls #100

Closed dlovellrw closed 8 years ago

dlovellrw commented 8 years ago

We tried this once before (https://github.com/weppos/publicsuffix-ruby/pull/79/commits/2799594e7f6b9095756d7367e88f9261961b7a59), only the branch became polluted with other changes. This ought to be clean.

What do you think? Travis is configured to use jruby? This is tested on jruby? The gem spec prohibits jruby.

It's only that we happen to be using jruby on one project, and we'd like to get off of the fork onto the main project.

weppos commented 8 years ago

What do you think? Travis is configured to use jruby? This is tested on jruby? The gem spec prohibits jruby.

Yes, the gem is tested and run with jRuby. https://travis-ci.org/weppos/publicsuffix-ruby/builds/124254553

For the sake of my curiosity, have you tried to reference the gem repo directly via Gemfile? Does it work?