search

weppos / publicsuffix-ruby

Domain name parser for Ruby based on the Public Suffix List.
https://simonecarletti.com/code/publicsuffix
MIT License
620 stars 109 forks source link

Add default excludes to .rubocop.yml #122

Closed dentarg closed 8 years ago

dentarg commented 8 years ago

You could think that the settings here would be merged with the defaults, but rubocop doesn't seem that smart.

dentarg commented 8 years ago

Seems like it didn't fully satisfy rubocop, oh well, now we at least know what to fix :-)

weppos commented 8 years ago

I've fixed it in ac3a881368c8c8ec57b5750014dab8d87cd23497

For now, I'll avoid to merge the changes (unless Rubocop will complain again). Thanks for the report.

dentarg commented 8 years ago

@weppos uhm don't you want the Travis builds to be green? You need to make rubocop exclude the vendor directory (Travis puts stuff there)

You are currently only excluding pkg/ from rubocup

dentarg commented 8 years ago

Look at why previous builds has failed (sorry I could have been more clear about that, thought the tests should become green, then it would have been obvious)

weppos commented 8 years ago

Yep, I misread the build.