search

weppos / publicsuffix-ruby

Domain name parser for Ruby based on the Public Suffix List.
https://simonecarletti.com/code/publicsuffix
MIT License
612 stars 110 forks source link

Ruby version upgrade should be major version upgrade #315

Closed nikita-nikolajev closed 4 weeks ago

nikita-nikolajev commented 4 weeks ago

ruby 2 to ruby 3 change should be a major version upgrade so <6 dependency does not suddenly break

weppos commented 4 weeks ago

ruby 2 to ruby 3 change should be a major version upgrade so <6 dependency does not suddenly break

You are absolutely right. I generally do it, it slipped through the cracks this time. Let me address it now.

eniomarques commented 4 weeks ago

ruby 2 to ruby 3 change should be a major version upgrade so <6 dependency does not suddenly break

You are absolutely right. I generally do it, it slipped through the cracks this time. Let me address it now.

Indeed, thanks! addressable (used by git) has a <6.0 and it caused some problems :) public_suffix (>= 2.0.2, < 6.0)

weppos commented 4 weeks ago

Both 5.1.1 (supporting Ruby 2.x) and 6.0.0 released.

nikita-nikolajev commented 4 weeks ago

thank you!