Update Gem to support Rails 5.1

weppos / tabs_on_rails

Tabs on Rails is a simple Rails plugin for creating and managing tabs and navigation menus.

https://simonecarletti.com/code/tabs-on-rails

MIT License

294 stars 52 forks source link

Update Gem to support Rails 5.1 #37

Closed ghost closed 7 years ago

ghost commented 8 years ago

Heya,

would you mind to update your gem to support Rails 5.1?

Currently you implemented its functionality by using before_filter. Those are deprecated are going to be removed with rails 5.1. They need to be replaced by before_action.

DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead. (called from set_tab at /home/user/.rvm/gems/ruby-2.3.0/bundler/gems/tabs_on_rails-01ba07eca6fb/lib/tabs_on_rails/action_controller.rb:106)

silviorelli commented 8 years ago

Pull request on topic: https://github.com/weppos/tabs_on_rails/pull/38

weppos commented 7 years ago

Closed by ca41c7b2a6486418094c21959ca3aab9d3cb0420