search

weppos / tabs_on_rails

Tabs on Rails is a simple Rails plugin for creating and managing tabs and navigation menus.
https://simonecarletti.com/code/tabs-on-rails
MIT License
294 stars 52 forks source link

before_filter deprecated, replaced with before_action #38

Closed silviorelli closed 7 years ago

silviorelli commented 8 years ago

before_filter replaced with before_action as deprecated in Rails 5.0. before_filter will be removed from Rails 5.1

weppos commented 8 years ago

@silviorelli thanks for the patch. As far as I remember, there is already another one but, like this one, it doesn't update the specs.

I generally don't merge patches without tests. If you want to add some, you can get some inspiration from https://github.com/weppos/breadcrumbs_on_rails/pull/80

silviorelli commented 8 years ago

I think the whole ci build process is broken. Anyway, probably a bigger job should be done like what has been done on breadcrumbs_on_rails, dropping support for older Ruby/Rails version on a new release.

weppos commented 7 years ago

Closed by ca41c7b2a6486418094c21959ca3aab9d3cb0420