search

weppos / whois-parser

An intelligent — pure Ruby — WHOIS parser.
https://whoisrb.org
MIT License
99 stars 102 forks source link

Update in.ua parser + update specs #135

Open jarthod opened 3 years ago

jarthod commented 3 years ago

Based on the work made by @Vanav in #69, here is a new PR that takes the latest version of the SUNIC WHOIS reply (yes it changed again), simplifies a bit the time parsing code to use parse_time, and update the specs with accurate new values, including time zone.

I also verified this code with a couple other in.ua hostnames I have and it worked fine with them. Let me know if there's anything that could be done better.

PS: I'm starting to use whois-parser for my service to notify about domain expiration (and maybe more later). So I have a lot of data about domains and TLD for which the parser is working or not (or has outdated definitions) and am ready to provide some (a lot of?) contributions if you are open. I just thought I would ask you first, not to spend too much time on this if you're not interested in them, let me know!

image

Thanks for this great work ! If this gets merged we can close #69

jarthod commented 3 years ago

@weppos little notch on this one 🙇‍♂️

Alternatively if you do not have the time to maintain this any more, as I have a good use for it in my service, I would be happy to help you!

jarthod commented 2 years ago

@weppos before I start another fork and try to merge most PR in it to get the gem to parse more domains (which means some users will keep having to find the best fork instead of using the main gem and keep rewriting the same fix other people did). Could you please clarify if you have abandoned the project? and if so if you prefer to let the gem like this (in which case I'll publish my fork under another name) or if you accept to pass it along? Thanks.

jarthod commented 2 years ago

For the record I ended up starting my fork in which I'll try to merge most PRs and fix outdated definitions (people who need these unmerged improvements can check it).

gem 'whois-parser', github: 'jarthod/whois-parser' # Unofficial but more up-to-date fork, check status at https://github.com/jarthod/whois-parser

Let me know if you want to catch up at some point.