search

weppos / whois

An intelligent — pure Ruby — WHOIS client and parser.
https://whoisrb.org
MIT License
1.13k stars 283 forks source link

Update to deprecation warning + word correction #640

Closed codytubbs closed 2 years ago

codytubbs commented 3 years ago

loophole@evilofallroot:~/rwhois$ ruby -e 'require "whois"; require "whois-parser"; puts Whois.whois("whois-pr.com").available?' Traceback (most recent call last): -e:1:in

': undefined method available?' for #Whois::Record:0x00005616807da040 (NoMethodError)

loophole@evilofallroot:~/rwhois$ ruby -e 'require "whois"; require "whois-parser"; puts Whois.whois("whois-pr.com").registered?' Traceback (most recent call last): -e:1:in <main>': undefined methodregistered?' for # (NoMethodError)

loophole@evilofallroot:~/rwhois$ ruby -e 'require "whois"; require "whois-parser"; puts Whois.whois("whois-pr.com").parser.available?' true

loophole@evilofallroot:~/rwhois$ ruby -e 'require "whois"; require "whois-parser"; puts Whois.whois("whois-pr.com").parser.registered?' false

codytubbs commented 3 years ago

Adding this for clarity after seeing https://github.com/weppos/whois/pull/633

[.available? dep warning]:

$ ruby -e 'require "whois"; require "whois-parser"; puts Whois.available?("whois-pr.com")'
DEPRECATION WARNING: Whois.available? is deprecated. Call Whois.whois("whois-pr.com").available?
true

[Attempt to follow .available? dep warning message]:

$ ruby -e 'require "whois"; require "whois-parser"; puts Whois.whois("whois-pr.com").available?'
Traceback (most recent call last):
-e:1:in `<main>': undefined method `available?' for #<Whois::Record:0x0000564d58126398> (NoMethodError)

[.registered? dep warning]:

$ ruby -e 'require "whois"; require "whois-parser"; puts Whois.registered?("whois-pr.com")'
DEPRECATION WARNING: Whois.registered? is deprecated. Call Whois.whois("whois-pr.com").available?
false

[Attempt to follow .registered? dep warning message]:

$ ruby -e 'require "whois"; require "whois-parser"; puts Whois.whois("whois-pr.com").registered?'
Traceback (most recent call last):
-e:1:in `<main>': undefined method `registered?' for #<Whois::Record:0x0000564e3759f318> (NoMethodError)

[Success after PR mod, for both .available? && .registered?]

$ ruby -e 'require "whois"; require "whois-parser"; puts Whois.whois("whois-pr.com").parser.available?'
true
$ ruby -e 'require "whois"; require "whois-parser"; puts Whois.whois("whois-pr.com").parser.registered?'
false