werdnanoslen / rishwat

Outing bribery in Pakistan
https://andyhub.com/demos/rishwat/www/
GNU General Public License v2.0
0 stars 0 forks source link

Search nearby without relying on place types #2

Closed werdnanoslen closed 7 years ago

werdnanoslen commented 7 years ago

Replace coordinates with something more useful. @ahkazim if the app can't figure out the name or address of a place the person indicated, what information would be better for location than coordinates?

werdnanoslen commented 7 years ago

Consider using vector to nearest landmark https://developers.google.com/maps/documentation/javascript/places#place_search_requests

ahkazim commented 7 years ago

I agree with suggestion

werdnanoslen commented 7 years ago

^ Not the best fix, as API requires selecting a type of place before searching. This makes me want to find a replacement for Google Places that provides the same or better variety of places (governmental, commercial, social, natural, etc) that supports purely proximal (without selecting type) searches

werdnanoslen commented 7 years ago

Factual seems to be one common suggestion, but it has since closed that option. OpenStreetMaps also has a lot of data, but much of it is simple latlng nodes without any other information (example). In order to do any better, we will need to create a custom database of POIs with human-readable names to base vectors on.

Until then, the types array is still not deprecated, nor is the establishment type, despite it being well past Google's announcement they would be. When that time comes, update this section https://github.com/werdnanoslen/rishwat/blob/master/www/js/controllers/AddCtrl.js#L299