search

wereHamster / github-types

This package includes (some) type definitions for objects which are consumed or produced by the GitHub v3 API
http://hackage.haskell.org/package/github-types
MIT License
3 stars 1 forks source link

github package #1

Open phadej opened 8 years ago

phadej commented 8 years ago

FYI, there is http://hackage.haskell.org/package/github package, I'm not sure if it has all the definitions from yours package; but it might make sense not to duplicate them at least.

Cheers, maintainer of github

wereHamster commented 8 years ago

From a cursory look your package is missing the definitions for all the timeline events (https://github.com/wereHamster/github-types/blob/99616f2a8e8b8e6ccc9c5c694a4eb96b39be3b9a/src/GitHub/Types/Events.hs), which is the primary reason why I started this package.

phadej commented 8 years ago

I'm glad to add them, especially if you provide a PR :)

iphydf commented 7 years ago

I think it would make sense to put the types and json converters from "github" into "github-types", to keep that package small. The network code can stay in the "github" package.