Avoid duplicate data attributes due to string/symbol Hash keys

werein / x-editable-rails

Edit fields easily with X-Editable helper

https://wereinhq.com/guides/x-editable-rails

MIT License

155 stars 87 forks source link

Avoid duplicate data attributes due to string/symbol Hash keys #60

Closed laserlemon closed 9 years ago

laserlemon commented 9 years ago

When passing in a custom "model", duplicate data attributes are added to the resulting HTML tag, making it unpredictable as to which will be used.

Please review/merge #58 first.

jirikolarik commented 9 years ago

I appreciate your work on this gem.. We could also bump the version number what do you think @laserlemon ?

laserlemon commented 9 years ago

@jirikolarik Absolutely! Typically, the maintainer will bump the version when deemed necessary after merging pull requests. It seems like this warrants just a patch version release, so version 1.5.5.

jirikolarik commented 9 years ago

Great, I see that you already created PR for bump version so I'll merge it and do it next time when requested or necessary on my own.