search

werein / x-editable-rails

Edit fields easily with X-Editable helper
https://wereinhq.com/guides/x-editable-rails
MIT License
155 stars 87 forks source link

Old font awesome icons are used in calendar picker #98

Closed mlt closed 6 years ago

mlt commented 6 years ago

font-awesome-rails gem pulls newer version than https://github.com/werein/x-editable-rails/blob/master/vendor/assets/javascripts/editable/bootstrap-editable.js#L6110-L6112 expects. We got to replace icon-arrow-left with fa fa-arrow-left or alike. I'm not sure if that is the way to go in the light of fas vs fa in newer font awesome (v5).

For those looking for a quick workaround here is one ugly fix and another, or, alternatively,

$.fn.datepicker.DPGlobal.template = $.fn.datepicker.DPGlobal.template.replace(/icon-/g, "fa fa-");
mlt commented 6 years ago

vitalets/x-editable/issues/435