czs108
commented
6 years ago - Use _beginthreadex to replace CreateThread, it not safe when you use C runtime library
- The 4th param of ReadFile and WriteFile can't be NULL in low version Windows
Closed czs108 closed 6 years ago
czs108
commented
6 years ago czs108
commented
6 years ago Hope you can consider my issue about refactoring of command dispatch, that too many if-elseif isn't a good idea or design, it will make difficult for adding features, "Server::HandleInput" function will be too long to maintain.
werkamsus
commented
6 years ago Thanks for your input! I threw together the command system in very little time, I will keep your contribution in mind for the Refactor with GUI etc.
On Sat 13. Oct 2018 at 04:09, Chenzs108 notifications@github.com wrote:
Hope you can consider my issue about refactoring of command dispatch, that too many if-elseif isn't a good idea or design, it will make difficult for adding features, "Server::HandleInput" function will be too long to maintain.
— You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/werkamsus/Lilith/pull/18#issuecomment-429502967, or mute the thread https://github.com/notifications/unsubscribe-auth/ABcNu7T8oVtf06TnQCwbi5BG0uHhhT0rks5ukUtDgaJpZM4XXWj7 .