Closed cyrusduong closed 2 years ago
Ugh, could you try this commit https://github.com/werman/noise-suppression-for-voice/commit/b31564e1a5fc5906209a596dfb737486d3b482be ? Either compile yourself or wait until CI builds the artifacts.
Checking.
Latest build works - Thank you so much!
Thanks for checking, I'll make a new release then...
When using Retroactive Grace Period I think the normal grace period breaks.
Saying the word "Click", for example. Setting Retroactive VAD slider to 5, appears to unmute the beginning of the word, but the ending is now clipped/muted.
Does this bool always compute as true (since outblock will always be greater than the last index we record)? RnNoiseCommonPlugin.cpp#L156
Should
outblock->idx
andlastBlockIdx
be swapped or the result passed tofabs()
? Or only allow the retroactive check to only unmute.Alternatively... I'm not sure if we should check the blocks for over last VAD threshold. We already reduce that the muted state for any given block is
UNMUTED_VAD
orMUTED
from the grace and denoise above.Would it be sufficient to just
UNMUTE_RETRO_VAD
how many X blocks ahead of any instance ofUNMUTED_VAD
found?Sorry if this did not help, I am not familiar with C++ but I really like/and want to be able to use this plugin hopefully this is enough to figure out/reproduce the issue I am having?