search

werman / noise-suppression-for-voice

Noise suppression plugin based on Xiph's RNNoise
GNU General Public License v3.0
4.73k stars 228 forks source link

lv2 detects duplicate plugin #158

Open tleydxdy opened 1 year ago

tleydxdy commented 1 year ago

$ lv2ls lilv_world_add_plugin(): warning: Duplicate plugin https://github.com/werman/noise-suppression-for-voice lilv_world_add_plugin(): warning: ... found in file:///usr/lib/lv2/rnnoise_mono.lv2/ lilv_world_add_plugin(): warning: ... and file:///usr/lib/lv2/rnnoise_stereo.lv2/ (ignored)

System is Arch Linux, installed from the official repo

pallaswept commented 1 year ago

Same issue here. This is a problem in pipewire filter chains which use the URI to specify the plugin to use, so now it is impossible to select the stereo or mono variant of the plugin. Fortunately, PW works fine with the ladspa variants, but from what I've read (please correct me if I'm wrong) LV2 should always be preferred if there is a choice, so it would be nice to fix this up :)

Anyway thanks for the plugin, it does a really good job!

pallaswept commented 9 months ago

I sent a patch to the SIMD-enhanced version of the plugin which has been more recently maintained, it will work for this, too. Just one line to change:

https://github.com/werman/noise-suppression-for-voice/blob/c1cf4307c75abed8e3ecccdd23a35f7782feaf69/src/juce_plugin/CMakeLists.txt#L45

Change from

LV2URI "https://github.com/werman/noise-suppression-for-voice"

to

LV2URI "https://github.com/werman/noise-suppression-for-voice#${default_channels}ch"

Simple, minimal, but effective fix. Enjoy.