search

wernerd / ZRTPCPP

C++ Implementation of ZRTP protocol - GNU ZRTP C++
Other
116 stars 50 forks source link

used for simulating "make dist" build target behavior and some linking #2

Open ghost opened 12 years ago

ghost commented 12 years ago

Just what I am using to build official dist tarballs. I also added extra library linkage for the demos since the stand-alone cmake builds would not work in (debian) chroot package builders otherwise...

wernerd commented 12 years ago

David,

thanks, looks good to me. I'm just working on a new release (2.3.0) and I will implement the changes in that release.

Regards, Werner

Am 25.06.2012 21:01, schrieb David Sugar:

Just what I am using to build official dist tarballs. I also added extra library linkage for the demos since the stand-alone cmake builds would not work in (debian) chroot package builders otherwise...

You can merge this Pull Request by running:

git pull https://github.com/dyfet/ZRTPCPP master

Or you can view, comment on it, or merge it online at:

https://github.com/wernerd/ZRTPCPP/pull/2

-- Commit Summary --

  • revised make for self contained builds and dist
  • versions must match

-- File Changes --

M CMakeLists.txt (22) M demo/CMakeLists.txt (4) M directive (2)

-- Patch Links --

https://github.com/wernerd/ZRTPCPP/pull/2.patch https://github.com/wernerd/ZRTPCPP/pull/2.diff

Reply to this email directly or view it on GitHub: https://github.com/wernerd/ZRTPCPP/pull/2

Werner Dittmann Werner.Dittmann@t-online.de Tel +49 176 993 462 95 PGP key: 82EF5E8B

wernerd commented 12 years ago

David,

the changes you made to the CMakeLists.txt in the demo directory don't work in my environment. I'm building ZRTP standalone and not as part of a larger project. Thus the "ccrtp" and "commoncpp" are not defined and are also not required.

Ween building libzrtpcpp with ccRTP support I link in ccrtp which in turn links to ucommon and commoncpp. This is covered in the top CMakeLists.txt inside the 'if(enable_ccrtp)' part.

Regards, Werner

Am 25.06.2012 21:01, schrieb David Sugar:

Just what I am using to build official dist tarballs. I also added extra library linkage for the demos since the stand-alone cmake builds would not work in (debian) chroot package builders otherwise...

You can merge this Pull Request by running:

git pull https://github.com/dyfet/ZRTPCPP master

Or you can view, comment on it, or merge it online at:

https://github.com/wernerd/ZRTPCPP/pull/2

-- Commit Summary --

  • revised make for self contained builds and dist
  • versions must match

-- File Changes --

M CMakeLists.txt (22) M demo/CMakeLists.txt (4) M directive (2)

-- Patch Links --

https://github.com/wernerd/ZRTPCPP/pull/2.patch https://github.com/wernerd/ZRTPCPP/pull/2.diff

Reply to this email directly or view it on GitHub: https://github.com/wernerd/ZRTPCPP/pull/2

Werner Dittmann Werner.Dittmann@t-online.de Tel +49 176 993 462 95 PGP key: 82EF5E8B

ghost commented 12 years ago

I had trouble linking it completely stand-alone without those changes...Odd....