search

wernerd / ZRTPCPP

C++ Implementation of ZRTP protocol - GNU ZRTP C++
Other
115 stars 50 forks source link

Header files are broken, makes zrtpcpp incompatible #20

Open Lekensteyn opened 9 years ago

Lekensteyn commented 9 years ago

Since commit 966c65d4bf7a6fe616abe880ab64eea49f07b8cb, namespace ost has been replaced by the macro NAMESPACE_COMMONCPP. This breaks external uses of some headers. What is the idea behind this? The commit message itself is useless.

In commit a50f981ae24ebfe504c9e727dccdb407a8cdfd21, external usage of ZrtpQueue.h has further been broken. While PR #17 could fix this, it breaks all existing applications which do not have the --cflags from pkg-config added to their CXXFLAGS/CPPFLAGS.

Can these two specific changes be reverted to avoid breaking the interface used by sflphone?

wernerd commented 9 years ago

These changes are 4 and 3 years old and other applications already changed to the new version, including the newer ccrtp library. IIRC the namespace change was necessary because of a new support lib for GNU RTP ccrtp library. ZrtpQueue depends on ccrtp because it's the glue code between the core ZRTP library and ccrtp.

Werner

Am 11.01.2015 um 11:33 schrieb Peter Wu:

Since commit 966c65d https://github.com/wernerd/ZRTPCPP/commit/966c65d4bf7a6fe616abe880ab64eea49f07b8cb, |namespace ost| has been replaced by the macro |NAMESPACE_COMMONCPP|. This breaks external uses of some headers. What is the idea behind this? The commit message itself is useless.

In commit a50f981 https://github.com/wernerd/ZRTPCPP/commit/a50f981ae24ebfe504c9e727dccdb407a8cdfd21, external usage of |ZrtpQueue.h| has further been broken. While PR #17 https://github.com/wernerd/ZRTPCPP/pull/17 could fix this, it breaks all existing applications which do not have the |--cflags| from pkg-config added to their CXXFLAGS/CPPFLAGS.

Can these two specific changes be reverted?

— Reply to this email directly or view it on GitHub https://github.com/wernerd/ZRTPCPP/issues/20.

Werner Dittmann email: Werner.Dittmann@t-online.de cell: +49 173 44 37 659 PGP key: 82EF5E8B

Lekensteyn commented 9 years ago

Hey Werner, thank you for your reply.

When I said ZrtpQueue.h, I meant zrtpccrtp.h. The ccrtp dependency is no issue for the application (sflphone) which is incompatible with this fork.

It looks like someone has to fix sflphone to work with this newer version.

What is the relation of this repo and the FTP tarballs on http://www.gnutelephony.org/index.php/GNU_ZRTP? I could not find a source repository on that wiki, and there has not been a FTP release since 2013.

wernerd commented 9 years ago

The ZRTP master is on Github only since several years. I asked the maintainer of the gnu telephony site to remove the old stuff because it confuses other projects/people :-) .

Werner

Am 11.01.2015 um 14:47 schrieb Peter Wu:

Hey Werner, thank you for your reply.

When I said ZrtpQueue.h, I meant zrtpccrtp.h. The ccrtp dependency is no issue for the application (sflphone) which is incompatible with this fork.

It looks like someone has to fix sflphone to work with this newer version.

What is the relation of this repo and the FTP tarballs on http://www.gnutelephony.org/index.php/GNU_ZRTP? I could not find a source repository on that wiki, and there has not been a FTP release since 2013.

— Reply to this email directly or view it on GitHub https://github.com/wernerd/ZRTPCPP/issues/20#issuecomment-69495006.

Werner Dittmann email: Werner.Dittmann@t-online.de cell: +49 173 44 37 659 PGP key: 82EF5E8B

Lekensteyn commented 9 years ago

README.md still refers to the "old stuff", maybe updating that would be a start :-)

(slightly off-topic: it would be nice if the NEWS file could use a formatting which includes the date for version numbers for posterity)