wernerfred / check_synology

This plugin will check a lot of different values on your Synology DiskStation.
MIT License
17 stars 25 forks source link

feat: Fix and improve state evaluation for "disk status" check #28

Closed amotl closed 2 years ago

amotl commented 2 years ago

Dear Frederic,

it's me again ;]. While looking at the code in more detail, we discovered a minor flaw and thought it would be a good idea to submit a patch. Beforehand, the code would only detect disk status SystemPartitionFailed, while Crashed would have been missed.

After fixing that, the code has been expanded to offer a more general approach for converging sensor states of multiple items (here: disks) into a single outcome state. Now, the state evaluation flow is more linear and can easily be reused for all other checks involving multiple items. We hope you like it.

With kind regards, Andreas.