search

wernerfred / check_synology

This plugin will check a lot of different values on your Synology DiskStation.
MIT License
17 stars 25 forks source link

Made SNMP privacy protocol selectable #41

Closed dommi22m closed 8 months ago

dommi22m commented 2 years ago

This is my version to make the privacy protocol selectable. AES128 is used as default.

dommi22m commented 2 years ago

Please add the new option [-s [AES128|DES]] to the usage in the README.md accordingly.

Done!

Why specifically did you choose -s? Maybe we should change this to -e(encryption?) to save -s for future usecases that are more related to the letter s? What's your opinion on that?

Yes you are right! I was thinking in the direction of "secret". But that would not be logical and also wrong in terms of content.

wernerfred commented 2 years ago

@all-contributors add @dommi22m for code

allcontributors[bot] commented 2 years ago

@wernerfred

I've put up a pull request to add @dommi22m! :tada: