search

wernerjoss / grav-plugin-ipcount

The IPcount Plugin is for Grav CMS. It counts the visitors on your Website
MIT License
3 stars 1 forks source link

Chart template improvements #3

Closed hughbris closed 2 years ago

hughbris commented 2 years ago

I was browsing your repo and noticed the word 'Cumulative' in the chart label and thought that sounded strange. I have to admit I'm not sure if it's actually incorrect, but my partner who is a communications professional says it should either be 'Accumulated' or 'Cumulative'. I don't know the difference.

I then realised this string should ideally be translatable, so added this functionality.

The other part of this PR is escaping the '<' symbol, as that is unsafe for HTML parsers even though it renders just fine in my Firefox.

wernerjoss commented 2 years ago

thanks for the patch, Hugh, contributions/suggestions/pull requests are always welcome :smile: also, I think you are right with 'Accumulated', I found nothing better than 'Cumulated' so far, but that is no wonder, english is not my native language..