wert007 / commit-analyzer

Gets the time somebody worked on something from `git log`
MIT License
1 stars 1 forks source link

[Question] "Multiple" or "Multiply"? #10

Closed kevinmatthes closed 2 years ago

kevinmatthes commented 2 years ago

Regarding the option documentation, I am unsure whether it should rather be "multiply" instead of "multiple".

After all, the word annotates the verb "specify", right? From my point of view, this would actually require an adverb... Did you already check it with languagetool or so?

If a change should be necessary, I would suggest to add it to #9.

wert007 commented 2 years ago

multiple, since it reads more like "multiple values specified".

kevinmatthes commented 2 years ago

And did you languagetool it or something similar?

Furthermore, why do the descriptions use French Spacing although English in general does not?

kevinmatthes commented 2 years ago

Another point: should not the option descriptions rather use Imperative / Present instead of Indicative / Simple Present, as Cargo does it, for example?

kevinmatthes commented 2 years ago

Regarding #7, I just added the description for --help to #9 since it already applies Imperative / Present.

wert007 commented 2 years ago

And did you languagetool it or something similar?

I asked @Ranplax

Furthermore, why do the descriptions use French Spacing although English in general does not?

I'm not sure what you mean by French Spacing 😅

wert007 commented 2 years ago

Another point: should not the option descriptions rather use Imperative / Present instead of Indicative / Simple Present, as Cargo does it, for example?

I guess you are right. I just wrote them without overthinking them too much 😅

kevinmatthes commented 2 years ago

French Spacing is a LaTeX feature. In languages like English or Italian, it is common to place two space characters after finishing a phrase (. ! ? : ‽ ...). Languages like French or German just place one space character after a phrase was ended. LaTeX's babel cares for the correct style, by default.

But when authoring software, software engineers need to care for this convention themselves since there is no LaTeX to fix it automatically (except for Doxygen but only in PDF mode). This is why I would like to outline that we need to agree on how to handle French Spacing.

For instance, my fixes of the usage function do not use French Spacing (Usage: commit-analyzer) which is correct in the terms of English typography but your option descriptions do use French Spacing which is often considered a mistake. A common style for such things helps to keep the application's overall appearance tidy.

wert007 commented 2 years ago

I see. And where exactly do we have French spacing?

kevinmatthes commented 2 years ago

Just like Cargo's clippy lints and fixes Rust code, there are also linters for natural languages. languagetool is one of them. It is a website where you enter the text to lint and it rates whether it is correct. It supports many languages and even some common dialects of them.

Before ending up in a dispute about adverbs, such a natural language linter usually helps to solve such grammar issues since it is a neutral and objective instance.

kevinmatthes commented 2 years ago

I see. And where exactly do we have French spacing?

In the option descriptions. Always at the beginning of the second phrase, there is just one space character.

wert007 commented 2 years ago

Hmm, I can not find examples, where this is used with full stops. Do you have maybe some?

wert007 commented 2 years ago

Hmm, I can not find examples, where this is used with full stops. Do you have maybe some?

kevinmatthes commented 2 years ago

In my fork, the first occurrence of French Spacing is at line 15 of src/main.rs:

            "Filters after certain author names. ORs if multiple specified.",

But instead, it should rather be without French Spacing:

            "Filters after certain author names.  ORs if multiple specified.",

Indeed, this is a very small detail. But it is still part of the project. And in my opinion, since we discussed whether or not to place syntactically possible but obsolete semicolons in #6, we should also care for this detail.

If you want to see the differences with and without French Spacing in action in a larger text, do the following:

You will definitely encounter a difference. This difference should be minded when writing text in a language which does not apply French Spacing. And as I said, English is one these languages. Proof: set your babel of the concerning project to another language, and compare the differences of the results as described above, such as with british vs. ngerman, for instance.

wert007 commented 2 years ago

But you are comparing here a mono spaced font with a variable spaced font. E.g. if I copy text from the English wikipedia

Computer programming is the process of performing a particular computation (or more generally, accomplishing a specific computing result), usually by designing and building an executable computer program. Programming involves tasks such as analysis, generating algorithms, profiling algorithms' accuracy and resource consumption, and the implementation of algorithms (usually in a chosen programming language, commonly referred to as coding).

There is only one space after each full stop. However that space will be rendered does not matter too much imho.

kevinmatthes commented 2 years ago

On the other hand, avoiding of French Spacing is practiced in order to recognise the end of phrase more easily. This also holds true for source code.

wert007 commented 2 years ago

On the other hand, avoiding of French Spacing is practiced in order to recognise the end of phrase more easily. This also holds true for source code.

Do you have any example of source code for that? Except of latex settings I do not really find anything for that..

kevinmatthes commented 2 years ago

The license header of the former does not apply French Spacing and my documentation strings neither. To me, this looks more readable. Just like the GPL 2.0 itself; see the latter link for an example.

wert007 commented 2 years ago

I meant in other code bases. I expected you, to use the spacing style you're advocating for.. 😅

kevinmatthes commented 2 years ago

GNU Octave: https://github.com/gnu-octave/octave

kevinmatthes commented 2 years ago

GCC: https://github.com/gcc-mirror/gcc

kevinmatthes commented 2 years ago

The GNU Shell Intrinsics: https://github.com/coreutils/coreutils

wert007 commented 2 years ago

Thanks for your examples, but I have to admit, I'm not a fan of it.

But thanks anyway, I wasn't aware, this exists. But I think we should stick with singular spaces.

kevinmatthes commented 2 years ago

In summary:

By the way what did languagetool or any other English linter say to "ORs if multiple specified."?

wert007 commented 2 years ago

Yes.

I didn't ask it. I'm open to other wordings in general though. But I'm pretty sure, that multiple is correct, since it is not referring to "specified".

kevinmatthes commented 2 years ago

And to which actually contained word it refers if not to specified?

wert007 commented 2 years ago

multiple, since it reads more like "multiple values specified".

An implied "values"

kevinmatthes commented 2 years ago

languagetool accepts both; how about just changing the wording to clarify? To me, it still looks like "multiple" refers to "specified".

How about "ORs if specified multiple times"?

wert007 commented 2 years ago

"ORs if specified multiple times" sounds good 👍

kevinmatthes commented 2 years ago

Fine!