search

wert007 / commit-analyzer

Gets the time somebody worked on something from `git log`
MIT License
1 stars 1 forks source link

[Bug] Crash Due to Missing LOC Diff #16

Closed kevinmatthes closed 2 years ago

kevinmatthes commented 2 years ago

It seems as if commit-analyzer tends to crash if no LOC diff is present in the input file.

Now, that the verbose output needs to be opted-in explicitly, I found out that line 121 always seems to cause a CommitParseError::CommitMissing when there is no LOC diff.

I did not trace down the bug completely, yet, but I assume that perhaps the LOC diff might be considered present, by default.

wert007 commented 2 years ago

I'll look into it.

kevinmatthes commented 2 years ago

I already suggested a patch with sane further enhancements, see #17.

wert007 commented 2 years ago

Hmm, lets talk about timing. I actually figured the bug out. I would push it to main first, and we'll look afterwards into your pull request, is that fine by you?

kevinmatthes commented 2 years ago

:heavy_check_mark: