search

wertarbyte / triggerhappy

A lightweight hotkey daemon
GNU General Public License v3.0
268 stars 47 forks source link

Add optional support for systemd socket activation #7

Closed andrewshadura closed 8 years ago

andrewshadura commented 9 years ago

This commit adds systemd socket activation and notification interface. Please consider merging it.

(This PR is a duplicate of #6 after I have accidentally closed it)

wertarbyte commented 9 years ago

I cherry-picked the top commit, but I cannot test it since I do not run systemd. Can you test the branch systemd?

andrewshadura commented 9 years ago

Well, if you cherry-picked it it should work (as I checked, the diff seems to be the same). The only thing I noticed (a bit late though) is that probably it's worth changing my email from my personal address to andrew.shadura@collabora.co.uk.

andrewshadura commented 9 years ago

@wertarbyte, anything on this since then?

andrewshadura commented 8 years ago

@wertarbyte, ping again.

wertarbyte commented 8 years ago

I cherry-picked your change in my local build branch, so it'll be included in the new packet :-) I just wasn't able to push it to github for now since I cannot reach the right SSH key at the moment.

andrewshadura commented 8 years ago

Thanks! In any case, I have rebased the commit and edited S-O-B and the author field — and GPG-signed it too. If you wish, pull this commit instead :)

andrewshadura commented 8 years ago

Merged as 9a760dcc7c9a8c7859d7bde5bd3dfc4c06ebe17d.

andrewshadura commented 8 years ago

However, the Debian packaging doesn't install the systemd unit files, could you please fix that?

wertarbyte commented 8 years ago

I've created the triggerhappy package 0.4.0-2 yesterday which should fix this issue. It's sitting on mentors and should will be uploaded later today :-)

andrewshadura commented 8 years ago

I have reviewed your packaging, there's a couple more things to fix. I'll post a patch here in a moment.