wesaynih / infrastructure

© 2016 The Knights Who Say NIH — Do NOT fork this repository without permission.
http://frameless.io/
Other
0 stars 1 forks source link

Add JSON validation to testing pipeline #33

Closed Robbert closed 8 years ago

Robbert commented 8 years ago

A syntax error in a .json file should never be commited, therefore we should parse all (changed) *.json files and detect syntax errors.

Robbert commented 8 years ago

Additionally there are files that have the application/json media type, but not the extension. An example that already is in this repository: frameless.sublime-project. Of course these should be valid too. In a second iteration, we can create a mapping of file name extensions to media types, and generate the filename selector in the gulp.src() pattern based on query for all file name extensions that are application/json.

Robbert commented 8 years ago

Split off the "file lookup via media type" idea into issue #34. Now commit 666a84c completely resolves this issue.