saving-throws not saved

wesbaker / roll20-character-sheets

Character sheet templates created by the community for use in Roll20.

MIT License

4 stars 2 forks source link

saving-throws not saved #16

Closed elbj closed 4 years ago

elbj commented 4 years ago

Hello

I have an issue. When I input any SavThr then close the sheet, they are not saved and their value is 0 when I open the sheet.

Regards

elbj commented 4 years ago

My bad ! I did not realise they where automaticaly calculated.

elbj commented 4 years ago

Sorry but there is really an issue with saving throws. Create a monster, set HD, see the values are correct, close sheet, open sheet, they are all 0.

wesbaker commented 4 years ago

@elbj thanks for reporting this. I'll dig into it tomorrow morning.

wesbaker commented 4 years ago

@elbj just giving you a heads up that I think I've found the issue, but Roll20 is having all sorts of issues this morning with the Custom Sheet Sandbox which is making it hard to test. I'll see what I can do this weekend to get it fixed.

wesbaker commented 4 years ago

Alright I was able to test it just uploading the sheet into a custom game and it looks like it's fixed. I'm going to push it up now so it's ready to go Tuesday.

elbj commented 4 years ago

Great.

By the way, do you want French translations ?

wesbaker commented 4 years ago

By the way, do you want French translations ?

If you're willing to make them, certainly!

elbj commented 4 years ago

Got it already. How can I give it to you ?

wesbaker commented 4 years ago

Got it already. How can I give it to you ?

If you're comfortable with GitHub you can make a pull request. If not, you can either paste it in here or put it in a gist and send me the link.

elbj commented 4 years ago

I'll try the pull request

elbj commented 4 years ago

No finally : https://gist.github.com/elbj/012db84c9286b15dc2dcbde6903830de Is it ok ?

wesbaker commented 4 years ago

It looks good, but you're missing a few that I just added. Take a look at the latest that I have currently in pull request: https://github.com/wesbaker/roll20-character-sheets/blob/ose-1.3.0/Old%20School%20Essentials%20-%20AAC/translation.json. I think you're just missing these:

  "reaction": "Reaction",
  "reaction-hostile": "Hostile, attacks",
  "reaction-unfriendly": "Unfriendly, may attack",
  "reaction-neutral": "Neutral, uncertain",
  "reaction-indifferent": "Indifferent, uninterested",
  "reaction-friendly": "Friendly, helpful",
  "charisma-modifier": "Charisma Modifier"

elbj commented 4 years ago

"reaction": "Réaction", "reaction-hostile": "Hostile, attaque", "reaction-unfriendly": "Inamical, peut attaquer", "reaction-neutral": "Neutre, incertain", "reaction-indifferent": "Indifférent, désintéressé", "reaction-friendly": "Amical, serviable", "charisma-modifier": "Modificateur de Charisme"

wesbaker commented 4 years ago

Done! Thanks for your contribution.

elbj commented 4 years ago

You're welcome