wesbos / Wes-Bos-Captions

Captions for my video courses
478 stars 321 forks source link

Typo fix #14

Closed StommePoes closed 7 years ago

StommePoes commented 7 years ago

This one's probably not an easy merge, for one reason:

Normally in English, punctuation is supposed to be inside quotes:

"Foo foo bar," she said.
"Foo?" he asked.
Then she said "Foo!" Later, another sentence started.

When speaking code that is to be written or is being written, however... that can cause problems, especially with dots. So most of the time, where I've changed literal words into code, I've placed the sentence punctuation outside the quote. That not only looks weird, but someone might know if there's a better way. In books like O'Reilly, a word like this would have monospacing and a slight background colour which does not include any sentence punctuation, but I don't know of a way to do this with captions.

For words where the thing being referred to is both a JavaScript or React term and also a normal English term, I've wrapped these in single quotes. So mostly tag names, 'this', and sometimes the word 'state'. Component names when the name of the component is being referenced has been captialised (Fish, App, StorePicker). HTML, jQuery, ES6 have received their capitalisations.

On some videos, there's talk of fish (the fish being ordered), Fish (the component), and "fish" (something being typed in). I tried to keep the quotes and punctuation right for the thing... if you're saying "type this text in" I held the punctuation out, but sometimes when you're reading an Error message then it's as if you're just quoting another person and I tried to keep the punctuation in the quotes. But it's kinda messy.

In some of the other videos, the captioner added () after some function names to make them even clearer as functions. I've done this in places too but worry it's not consistent enough. Esp sometimes you say "dot map", sometimes you verb it ("now we're going to map these to that") and sometimes just referencing the actual function map()... I hope it's straight.

There is one place on one video where only 1 set of time is used, meaning a whole sentence is heard without it being seen. However I'm uncertain enough of the timing of captions that I didn't try to add another time chunk and we want to generally avoid 3 lines of text onscreen at once. If someone more into captions comes along, I will find and reference that video and timestamp.

wesbos commented 7 years ago

wooow - this is amazing. The quality of these just went up a whole level.

Thanks so much