search

wesbos / cobalt2-vscode

Cobalt2 Theme for VS Code
MIT License
767 stars 251 forks source link

Fragmented background #156

Closed hiddenman closed 3 years ago

hiddenman commented 4 years ago

Hi there,

Some themes, including Cobalt2, running on VS Code 1.42.1, have fragmented background everywhere (see the screenshot). Looks like VSCode changes background only around text, not the whole screen. Screenshot from 2020-02-18 11-41-02

marcelluseasley commented 4 years ago

I agree. I am experiencing the same thing. It's a nice theme, but that will probably be a deal beaker or me.

hiddenman commented 4 years ago

I agree. I am experiencing the same thing. It's a nice theme, but that will probably be a deal beaker or me.

Hi, I already discovered that the issue is not related to the theme itself. It's Electron on Linux problem. Just run it as "code --disable-gpu" and everything will be OK. Here is the link to my another issue where you can find the link to the first issue with this: https://github.com/microsoft/vscode/issues/91638

HellPie commented 4 years ago

This also happens on Windows for me on a 1440p display.

It happens with all color themes except the high contrast theme. It also appears to generate weird artifacts in some UI elements, like the search bar in settings. Disable hardware acceleration fixes the problem and judging by the change in brightness of the editor it might be related to HDR support on the monitor or some other weird rendering problem, likely tied to Electron more than Visual Studio Code but I didn't notice any issue with Discord Canary or Discord Stable builds and other Electron apps.

Disabling hardware acceleration has a noticeable drop in performance to the point where I can clearly see VSCode (and Discord too) struggling a lot to keep a stable framerate, with consistent drops, microlag and very, very annoying all-round janky UI.

Trying out the VSCode playground on the Azure-hosted website doesn't show the problem in Chrome 84 (I don't have other versions of Chrome installed) with hardware acceleration enabled.

Edit: It's definitely somehow related to HDR on Windows at least as disabling it from system settings solves the issue even when using GPU acceleration. I don't know if someone opened an issue on the Electron tracker and I don't really know how that one works, would be nice if someone were to maybe add this there if it helps track down the issue.

Annotation 2020-04-29 150617 Screenshot (11) Screenshot (12) Screenshot (13) Screenshot (14)

IllusionMH commented 4 years ago

There is an open issue for HDR on Windows and workaround described in https://github.com/microsoft/vscode/issues/88491#issuecomment-589527628. As linked above - workaround for Linux will be https://github.com/microsoft/vscode/issues/85452#issuecomment-558334562

It doesn't looks like issues with partial background should be tracked in this repo.

wesbos commented 3 years ago

thanks everyone - doesn't look like this is related to my theme, but VS code? Closing but feel free to reopen if i am wrong