search

wesbos / cobalt2

Tweaked and refined Sublime Text theme based on the original cobalt.
1.57k stars 156 forks source link

JS and TS changes for VS Code #151

Closed pjlamb12 closed 7 years ago

pjlamb12 commented 7 years ago

This PR fixes some JavaScript and TypeScript visual changes in VS Code. See attached pictures for the before and after. screenshot 3 screenshot 4

pjlamb12 commented 7 years ago

Relates to #144

codeofsumit commented 7 years ago

@pjlamb12 nice PR - how can I install your PR version into vscode until it gets merged?

dawsbot commented 7 years ago

What an awesome fix @pjlamb12! I'd love to see this merged so that the color-scheme is usable in vscode. I've had the task #144 open for 6 months at this point, and this would fix it!

wesbos commented 7 years ago

Asking for a few people to test this then I'll merge

alexkrolick commented 7 years ago
screen shot 2017-08-03 at 6 24 58 pm screen shot 2017-08-03 at 6 23 49 pm screen shot 2017-08-03 at 6 22 43 pm
adriangmweb commented 7 years ago

Finally any news with the merge?

ghost commented 7 years ago

Might need some README changes if this works for VSCode as well as Sublime, @pjlamb12.

alexkrolick commented 7 years ago

@evanread I used the VSCode Yeoman generator (yo code) to import the Textmate theme as an extension for the screenshots above

ghost commented 7 years ago

@wesbos You happy with the MR?

wesbos commented 7 years ago

looks good - thanks! I will push to VS code as soon as I can remember how...

alexkrolick commented 7 years ago

Are all the brackets supposed to be italics?

wesbos commented 7 years ago

nope - I'm getting into VS code so I'll give it a lookski