search

wesbos / cobalt2

Tweaked and refined Sublime Text theme based on the original cobalt.
1.57k stars 156 forks source link

compatibility sublime 3.1.1 #164

Open arnaudambro opened 6 years ago

arnaudambro commented 6 years ago

Hi Wes, or anybody else,

Your theme is no compatible anymore with the new version of Sublime Text, would somebody be nice and smart enough to update it ? I miss it soooo much... 😩

Cheers Arnaud

rosston commented 6 years ago

I'm using Sublime 3.1.1 build 3176 with Cobalt2 2.0.11 with no problems.

@arnaudambro, can you specify what version of Cobalt2 you're using? And can you maybe provide a screenshot and the relevant portion of your settings?

arnaudambro commented 6 years ago

Sure ! Here it is below. You can see that React props are no longer italic, and the green color of objects key changed, so has the green color of the imported stuff. screen shot 2018-05-18 at 15 34 51

arnaudambro commented 6 years ago

On that one you can see that the arrow functions are not in orange if there is a semi-colon after the state screen shot 2018-05-18 at 15 37 07

aaeabdo commented 6 years ago

@arnaudambro Wonder if you found a solution for this issue?

rosston commented 6 years ago

My strong hunch is that this was caused by updated syntax highlighting in Sublime 3.1 (build 3170). The release notes mention:

  • Many syntax highlighting improvements, including significant improvements to:
    • JavaScript, with thanks to Thomas Smith

For a temporary fix, you could try downgrading to Sublime Text 3.0 (build 3143) (by copying/editing the download links on the download page to refer to the desired build).

Longer term, I think this would require many patches to the cobalt2 syntax theme to fix. I don't use Sublime Text and am not really interested in fixing it myself, but here are some resources I found that could be useful for someone else to fix the issues: