search

wescalehq / mjml-processor

A thin wrapper around mjml to provide easy mjml rendering in java applications
Apache License 2.0
4 stars 6 forks source link

Update mjml.js to v4.5.1 #5

Open wwisser opened 4 years ago

wwisser commented 4 years ago

See https://github.com/mjmlio/mjml/releases

atomfrede commented 4 years ago

Hi @wwisser and thanks for the issue. Sadly we can't update right now (didn't check recently) but if I remember correctly new mjml release don't work with nashorn anymore.

skingsland commented 4 years ago

but if I remember correctly new mjml release don't work with nashorn anymore.

Do you have a link for this? I tried searching the MJML release notes and greater internet, but didn't find anything.

robinjoerke commented 2 years ago

I created a PR to switch to the latest openJDK nashorn version. this version of nashorn implements many ECMAScript 6 features. It might be possible that an update to an up to date mjml version is possible afterwards. (I could not figure out where the bundled mjml.js comes from or how it was created so i was not sure how to update it. as my priority was to get mjml-processor running with java17 i did not spend much time trying tu figure it out)

atomfrede commented 2 years ago

@robinjoerke As far as I remember, the existing mjml bundle was created via the not existing browser module. As such the latest mjml seems to work only with node runtime