wescalehq / mjml-processor

A thin wrapper around mjml to provide easy mjml rendering in java applications
Apache License 2.0
4 stars 6 forks source link

Make mjml-processor java14+ compatible #6

Open robinjoerke opened 2 years ago

robinjoerke commented 2 years ago

Hi, i wanted to use mjml-processor in a java17 project so i had to make some changes as nashorn is not published with java anymore starting with java 15. (was deprecated in java 11). I though a PR might be appreciated so here it is

Brief overview over the changes:

atomfrede commented 2 years ago

❤️ Thanks @robinjoerke . I can't merge it (anymore), but the PR is highly welcome. I guess you know how to use your updated version via jitpack?

robinjoerke commented 2 years ago

I already published it to a local private maven repo for my usecase. taht version is completely build on maven instead of gradle. but i ported back the changes i made to the gradle based version to make it accessible to others. if you say there is no way this will be merged and published here i could set up a jitpack repo based on my fork. (never done that before but im sure i would be able to fiure it out)